Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refinery-cli: update time crate #373814

Merged
merged 1 commit into from
Jan 19, 2025
Merged

refinery-cli: update time crate #373814

merged 1 commit into from
Jan 19, 2025

Conversation

szlend
Copy link
Member

@szlend szlend commented Jan 14, 2025 •
edited
Loading

Updates the time crate to 0.3.37 so it can build on Rust v1.80+

Upstream doesn't commit Cargo.lock. We rely on the lock file in crates.io. So I don't think this will be fixed upstream any time soon.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@szlend szlend requested review from pyrox0 and alyssais January 14, 2025 19:10
@szlend szlend added the backport release-24.11 Backport PR automatically label Jan 14, 2025
@nix-owners nix-owners bot requested a review from lucperkins January 14, 2025 19:18
@pyrox0
Copy link
Member

pyrox0 commented Jan 14, 2025 •
edited
Loading

Why was I requested for review? I am not a maintainer of this package

(note that you do not need to manually request reviews, the nix-owners bot will automatically request reviews from maintainers)

@szlend szlend removed the request for review from pyrox0 January 14, 2025 19:44
@alyssais
Copy link
Member

So I don't think this will be fixed upstream any time soon.

Upstream doesn't care about cargo install?

@szlend
Copy link
Member Author

szlend commented Jan 15, 2025 •
edited
Loading

Upstream doesn't care about cargo install?

I can't say, though there hasn't been any response since November in the upstream issue and it's been almost a year since the last stable release.

@vojtechkral
Copy link

vojtechkral commented Jan 15, 2025 •
edited
Loading

Upstream doesn't care about cargo install?

I think cargo install works unless you pass --locked

@szlend szlend requested a review from alyssais January 17, 2025 15:05
alyssais
alyssais approved these changes Jan 17, 2025
View reviewed changes
pkgs/by-name/re/refinery-cli/time-crate.patch
[[package]]
name = "deranged"
-version = "0.3.8"
+version = "0.3.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this updated, but I guess it can't hurt…

Copy link
Member Author

@szlend szlend Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the minimum version is 0.3.9, so it was actually necessary to bump it: https://github.com/time-rs/time/blob/main/Cargo.toml#L11C25-L11C30

Copy link
Member Author

@szlend szlend Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though that line hasn't changed in 2 years, so maybe my understanding of how cargo updates deps is wrong.

@lucperkins
Copy link
Contributor

lucperkins commented Jan 17, 2025 •
edited
Loading

I continue to be annoyed by the maintainers Git-ignoring the flake.lock but this is hardly the place to register that complaint 😄

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 19, 2025
@alyssais alyssais merged commit a8f4d20 into NixOS:master Jan 19, 2025
25 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 19, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 19, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais approved these changes

@lucperkins lucperkins lucperkins approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@szlend @pyrox0 @alyssais @vojtechkral @lucperkins @wegank